[Backport] Convert to string $option->getValue, in order to be compared with oth…#17476
Merged
magento-engcom-team merged 1 commit intomagento:2.1-developfrom Aug 10, 2018
mage2pratik:2.1-develop-PR-port-15720
Merged
[Backport] Convert to string $option->getValue, in order to be compared with oth…#17476magento-engcom-team merged 1 commit intomagento:2.1-developfrom mage2pratik:2.1-develop-PR-port-15720
magento-engcom-team merged 1 commit intomagento:2.1-developfrom
mage2pratik:2.1-develop-PR-port-15720
Conversation
…er saved options in previous cart items
VladimirZaets
approved these changes
Aug 9, 2018
Contributor
|
Hi @VladimirZaets, thank you for the review. |
magento-engcom-team
pushed a commit
that referenced
this pull request
Aug 10, 2018
… to be compared with oth… #17476
Contributor
|
Hi @mage2pratik. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#15720
#mm18it
…er saved options in previous cart items
Description
To decide whether a product with the same options is already present in the cart, magento makes a comparison with the string that represents the buyrequest in json format with those saved in the database. When a product is added by the Rest API the option code attribute encoded in the json is a number, whereas from the frontend context it is a string. In this case, this bufix forces the option attribute value in string, creating arrays that will later be converted into json
Fixed Issues (if relevant)
Manual testing scenarios
Same test performed by issue writer
Contribution checklist