Skip to content

[Forwardport] Improvements in UI component MassActions #17446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magento-engcom-team merged 3 commits into from
Aug 11, 2018
Merged

[Forwardport] Improvements in UI component MassActions #17446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
832bbae
Ui module fixes:
arendarenko Aug 7, 2018
55ec6a3
Ui module fixes:
arendarenko Aug 7, 2018
6a964ff
[Forwardport] Improvements in UI component
VladimirZaets Aug 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions app/code/Magento/Ui/view/base/web/js/grid/columns/multiselect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,15 @@ define([
return this;
},

/**
* Selects or deselects all records on the current page.
*
* @returns {Multiselect} Chainable.
*/
togglePage: function () {
return this.isPageSelected() ? this.deselectPage() : this.selectPage();
},

/**
* Clears the array of not selected records.
*
Expand Down
7 changes: 5 additions & 2 deletions app/code/Magento/Ui/view/base/web/js/grid/massactions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,11 +175,14 @@ define([
* invoked if action is confirmed.
*/
_confirm: function (action, callback) {
var confirmData = action.confirm;
var confirmData = action.confirm,
data = this.getSelections(),
total = data.total ? data.total : 0,
confirmMessage = confirmData.message + ' (' + total + ' record' + (total > 1 ? 's' : '') + ')';

confirm({
title: confirmData.title,
content: confirmData.message,
content: confirmMessage,
actions: {
confirm: callback
}
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Ui/view/base/web/templates/grid/columns/multiselect.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
data-bind="
checked: allSelected(),
attr: {id: ++ko.uid},
event: { change: toggleSelectAll },
event: { change: togglePage },
css: { '_indeterminate': indetermine },
enable: totalRecords">
<label attr="for: ko.uid"/>
Expand Down