Improvements in UI component MassActions #17437
Merged
magento-engcom-team merged 2 commits intomagento:2.2-developfrom Aug 8, 2018
arendarenko:fix-ui-grids-1
Merged
Improvements in UI component MassActions #17437magento-engcom-team merged 2 commits intomagento:2.2-developfrom arendarenko:fix-ui-grids-1
magento-engcom-team merged 2 commits intomagento:2.2-developfrom
arendarenko:fix-ui-grids-1
Conversation
- Update confirm message method, add number of selected records to confirm message
- Add multiselect.js new method that toggles page records and set it using in template and set up it in template file
Contributor
Contributor
|
Hi @alexeya-ven. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Contributor
|
@alexeya-ven thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
Contributor
|
Hi @alexeya-ven. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This improvements makes work with UI Grids and MassActions (which are using together) more comfortable. I had experienced cases when admin user accidentally delete all data when working with grids in backend (example: customers, orders, content, catalog) because by default when you're clicking on top checkbox in MassActions component, it's selects not only visible on page records (which is expectable), but all the records.
List of changes:
Manual testing scenarios
Contribution checklist