Skip to content

Remove unused use statement#17364

Closed
AnshuMishra17 wants to merge 1 commit intomagento:2.2-developfrom
AnshuMishra17:remove-unused-use-statement
Closed

Remove unused use statement#17364
AnshuMishra17 wants to merge 1 commit intomagento:2.2-developfrom
AnshuMishra17:remove-unused-use-statement

Conversation

@AnshuMishra17
Copy link
Copy Markdown
Contributor

Description

Removed the unused use statement.

Manual testing scenarios

  1. Perform catalog search and advance search from frontend.
  2. Save, edit, delete search term and search synonyms in admin.

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @AnshuMishra17. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sidolov
Copy link
Copy Markdown
Contributor

sidolov commented Aug 5, 2018

Hi @AnshuMishra17 , due to changes in Magento Code Contributions Guide we can't accept such Pull Requests to 2.2 release line. All code cleanup like typos, spelling mistakes, removing unused code, etc should be delivered to 2.3 release line.
Thank you!

@sidolov sidolov closed this Aug 5, 2018
@mage2pratik mage2pratik mentioned this pull request Aug 6, 2018
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants