[Forwardport] Remove PDF files after generation#17280
Merged
magento-engcom-team merged 5 commits intomagento:2.3-developfrom Aug 10, 2018
tiagosampaio:2.3-develop-PR-port-16401
Merged
[Forwardport] Remove PDF files after generation#17280magento-engcom-team merged 5 commits intomagento:2.3-developfrom tiagosampaio:2.3-develop-PR-port-16401
magento-engcom-team merged 5 commits intomagento:2.3-developfrom
tiagosampaio:2.3-develop-PR-port-16401
Conversation
Contributor
|
Hi @tiagosampaio. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Contributor
|
@tiagosampaio I've seen you routinely port other devs code. I'd rather have the original author doing the back/forward port when possible and you porting everything that's available is not helping with that. |
Member
Author
|
@miguelbalparda as you wish, Sr. |
This was referenced Aug 10, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Aug 10, 2018
Contributor
|
Hi @tiagosampaio. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#16401
Description
Upon invoice/packingslip/credit memo printing the system generates a PDF file directly in the
vardirectory. I see no reason for keeping these files since they are not accessible publicly via web (sharing purpose). There's no "reuse" purpose as well since on every print action a new file with a new filename is being generated.This PR provides a logic for removing a PDF file once it's generated.
Currently, it's implemented only within a scope of the invoice printing. Once we agree on the solution, I will adjust other places with PDF generation.
Fixed Issues (if relevant)
Manual testing scenarios
vardirectory.