[Backport] Resolved : Mobile device style groups incorrect order#17240
Merged
magento-engcom-team merged 1 commit intomagento:2.1-developfrom Aug 1, 2018
tiagosampaio:2.1-develop-PR-port-16959
Merged
[Backport] Resolved : Mobile device style groups incorrect order#17240magento-engcom-team merged 1 commit intomagento:2.1-developfrom tiagosampaio:2.1-develop-PR-port-16959
magento-engcom-team merged 1 commit intomagento:2.1-developfrom
tiagosampaio:2.1-develop-PR-port-16959
Conversation
ihor-sviziev
approved these changes
Jul 28, 2018
Contributor
|
Hi @ihor-sviziev, thank you for the review. |
4 tasks
Contributor
|
Hi @tejash-wagento, |
ihor-sviziev
approved these changes
Jul 30, 2018
Contributor
|
Hi @ihor-sviziev, thank you for the review. |
Contributor
|
Hi @tiagosampaio. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#16959
Description
Style groups for mobile devices (max-width) are specified in the wrong order.
In
lib/web/css/source/lib/_responsive.lessthe style groups run breakpoint-size ascending: 319px, 479px, 639px, 767px, which leads to outputting max-width media queries breakpoint-size ascending - the last-defined breakpoint overrides smaller screen size breakpoints...Fixed Issues (if relevant)
Style groups for mobile devices (max-width) are specified in the wrong order.
Expected result
CSS should be output as follows:
Actual result
CSS is output as follows:
Contribution checklist