[Backport] Fix for #14593 (second try #16431)#17223
Merged
magento-engcom-team merged 3 commits intomagento:2.1-developfrom Aug 1, 2018
Merged
[Backport] Fix for #14593 (second try #16431)#17223magento-engcom-team merged 3 commits intomagento:2.1-developfrom
magento-engcom-team merged 3 commits intomagento:2.1-developfrom
Conversation
ihor-sviziev
requested changes
Jul 28, 2018
| event.stopImmediatePropagation(); | ||
|
|
||
| /** @inheritdoc */ | ||
| always: function (e) { |
Contributor
There was a problem hiding this comment.
Could you describe why this code was added? I can't find this change in original PR.
Contributor
There was a problem hiding this comment.
Ah, just in order to be the same across all release lines. It's a good idea.
ihor-sviziev
approved these changes
Jul 28, 2018
| event.stopImmediatePropagation(); | ||
|
|
||
| /** @inheritdoc */ | ||
| always: function (e) { |
Contributor
There was a problem hiding this comment.
Ah, just in order to be the same across all release lines. It's a good idea.
Contributor
|
Hi @ihor-sviziev, thank you for the review. |
Contributor
|
Hi @gelanivishal. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#16477
Description
Preconditions:
Magento version 2.2.4 with luma theme
Step to reproduce:
Expected Result
Actual result
https://github.com/magento/magento2/blob/2.2-develop/app/code/Magento/Checkout/view/frontend/web/js/sidebar.js#L96
Fixed Issues
P.S.
First, pull request - #16431
Contribution checklist