[Backport] Admin controller product set save refactor#17222
Closed
gelanivishal wants to merge 1 commit intomagento:2.1-developfrom
Closed
[Backport] Admin controller product set save refactor#17222gelanivishal wants to merge 1 commit intomagento:2.1-developfrom
gelanivishal wants to merge 1 commit intomagento:2.1-developfrom
Conversation
ihor-sviziev
requested changes
Jul 28, 2018
Contributor
ihor-sviziev
left a comment
ihor-sviziev
left a comment
There was a problem hiding this comment.
This PR for some reasons not contains changes related to $model and $filterManager variables. As result - we have failing static tests.
Please re-check it
Contributor
|
Hi @gelanivishal , due to changes in Magento Code Contributions Guide we can't accept such Pull Requests to 2.1 release line. Code refactoring should be delivered to 2.2 or 2.3 release line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#16217
Description
Remove direct use of object manager for admin attribute set save controller using constructor based dependency injection.
Manual testing scenarios
Created a new attribute set in admin under Stores -> Attribute Set -> Add Attribute Set.
Edit an existing attribute set under Stores -> Attribute Set