[Backport 2.1] Fix "pattern" UI Component validation#17213
Merged
magento-engcom-team merged 2 commits intomagento:2.1-developfrom Aug 1, 2018
mageprince:mageprince-2.1-patch-pull-11565
Merged
[Backport 2.1] Fix "pattern" UI Component validation#17213magento-engcom-team merged 2 commits intomagento:2.1-developfrom mageprince:mageprince-2.1-patch-pull-11565
magento-engcom-team merged 2 commits intomagento:2.1-developfrom
mageprince:mageprince-2.1-patch-pull-11565
Conversation
latest 2.1 develop
ihor-sviziev
approved these changes
Jul 28, 2018
Contributor
|
Hi @ihor-sviziev, thank you for the review. |
Contributor
|
Hi @mageprince. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#11565
Description
Convert
paramstring to regular expression using constructor and test on theRegExpobject.Fixed Issues (if relevant)
Manual testing scenarios
Create a custom UI Component form
Add a
validationitem to an input fieldSpecify a
patternvalidation rule with a custom regular expression pattern. E.g.View form in admin browser and enter valid and invalid values (e.g.
3sdfandasd3)Original Pull Request
#13742
Contribution checklist