Skip to content

Using interface instead of model directly#17124

Merged
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
storefront-bvba:use-interface-instead-of-model-directly
Jul 29, 2018
Merged

Using interface instead of model directly#17124
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
storefront-bvba:use-interface-instead-of-model-directly

Conversation

@woutersamaey
Copy link
Copy Markdown
Contributor

@woutersamaey woutersamaey commented Jul 25, 2018

Description

Using interface instead of model directly

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @woutersamaey. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Copy Markdown
Contributor

@woutersamaey thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @woutersamaey. Thank you for your contribution.
We will aim to release these changes as part of 2.2.6.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants