Skip to content

Refactory to Magento_Backend module class.#17101

Merged
magento-engcom-team merged 3 commits intomagento:2.2-developfrom
tiagosampaio:2.2-develop-009
Aug 8, 2018
Merged

Refactory to Magento_Backend module class.#17101
magento-engcom-team merged 3 commits intomagento:2.2-developfrom
tiagosampaio:2.2-develop-009

Conversation

@tiagosampaio
Copy link
Copy Markdown
Member

@tiagosampaio tiagosampaio commented Jul 24, 2018 •
edited
Loading

Refactory of a class in Magento_Backend module.

Description

Simple refactory to Magento_Backend module class.

  • Turning protected properties into private ones.
  • Using dependency injection rather than using Object Manager directly.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Jul 24, 2018

Hi @tiagosampaio. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@tiagosampaio tiagosampaio mentioned this pull request Jul 24, 2018
Merged
4 tasks
@ihor-sviziev ihor-sviziev self-assigned this Jul 25, 2018
ihor-sviziev
ihor-sviziev requested changes Jul 25, 2018
View reviewed changes
Comment thread app/code/Magento/Backend/Helper/Dashboard/Order.php Outdated
* @var \Magento\Reports\Model\ResourceModel\Order\Collection
*/
protected $_orderCollection;
private $orderCollection;
Copy link
Copy Markdown
Contributor

@ihor-sviziev ihor-sviziev Jul 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not backward compatible. Please revert it.
More details: https://devdocs.magento.com/guides/v2.2/contributor-guide/backward-compatible-development/

Comment thread app/code/Magento/Backend/Helper/Dashboard/Order.php Outdated
* @since 100.0.6
*/
protected $_storeManager;
private $storeManager;
Copy link
Copy Markdown
Contributor

@ihor-sviziev ihor-sviziev Jul 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not backward compatible. Please revert it.
More details: https://devdocs.magento.com/guides/v2.2/contributor-guide/backward-compatible-development

Comment thread app/code/Magento/Backend/Helper/Dashboard/Order.php Outdated
\Magento\Framework\App\Helper\Context $context,
\Magento\Reports\Model\ResourceModel\Order\Collection $orderCollection
\Magento\Reports\Model\ResourceModel\Order\Collection $orderCollection,
\Magento\Store\Model\StoreManagerInterface $storeManager
Copy link
Copy Markdown
Contributor

@ihor-sviziev ihor-sviziev Jul 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make new constructor argument optional and as retrieve it by fallback from object manager.
More details: https://devdocs.magento.com/guides/v2.2/contributor-guide/backward-compatible-development

@tiagosampaio
Copy link
Copy Markdown
Member Author

tiagosampaio commented Jul 28, 2018

@ihor-sviziev changes were reverted.

ihor-sviziev
ihor-sviziev requested changes Jul 28, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good, but there still backward incompatible changes

Comment thread app/code/Magento/Backend/Helper/Dashboard/Order.php Outdated
* @var \Magento\Reports\Model\ResourceModel\Order\Collection
*/
protected $_orderCollection;
private $_orderCollection;
Copy link
Copy Markdown
Contributor

@ihor-sviziev ihor-sviziev Jul 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this change, it's not backward compatible

Comment thread app/code/Magento/Backend/Helper/Dashboard/Order.php Outdated
* @since 100.0.6
*/
protected $_storeManager;
private $_storeManager;
Copy link
Copy Markdown
Contributor

@ihor-sviziev ihor-sviziev Jul 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this change, it's not backward compatible

@ihor-sviziev
#17101 Refactory to Magento_Backend module class
9ff8983 
Revert backward incompatible changes
@ihor-sviziev
Copy link
Copy Markdown
Contributor

ihor-sviziev commented Jul 28, 2018

I fixed these small issues myself. Let's wait for Travis results

@ihor-sviziev ihor-sviziev self-requested a review July 28, 2018 21:30
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.7 milestone Aug 7, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Aug 7, 2018

Hi @ihor-sviziev, thank you for the review.
ENGCOM-2687 has been created to process this Pull Request

@tiagosampaio
Copy link
Copy Markdown
Member Author

tiagosampaio commented Aug 7, 2018

Thanks @ihor-sviziev.

@magento-engcom-team magento-engcom-team merged commit 9ff8983 into magento:2.2-develop Aug 8, 2018
magento-engcom-team pushed a commit that referenced this pull request Aug 8, 2018
ENGCOM-2687: Refactory to Magento_Backend module class. #17101
a35e44b
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Aug 8, 2018

Hi @tiagosampaio. Thank you for your contribution.
We will aim to release these changes as part of 2.2.7.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

Labels

Component: Backend Progress: accept Release Line: 2.2

Projects

None yet

Milestone

Release: 2.2.7

Development

Successfully merging this pull request may close these issues.

3 participants

@tiagosampaio @magento-engcom-team @ihor-sviziev