[Backport] Fixed comparison with 0 bug for TableRate shipping carrier#17089
Merged
magento-engcom-team merged 1 commit intomagento:2.1-developfrom Jul 26, 2018
mageprince:2.1-develop-PR-port-13831
Merged
[Backport] Fixed comparison with 0 bug for TableRate shipping carrier#17089magento-engcom-team merged 1 commit intomagento:2.1-developfrom mageprince:2.1-develop-PR-port-13831
magento-engcom-team merged 1 commit intomagento:2.1-developfrom
mageprince:2.1-develop-PR-port-13831
Conversation
In free shipping flow sometimes you ca get such query to DB: SQL: SELECT `shipping_tablerate`.* FROM `shipping_tablerate` WHERE ... BIND: array ( ':website_id' => 1, ':country_id' => 'US', ':region_id' => 12, ':postcode' => '68138', ':condition_name' => 'package_value', ':condition_value' => -3.5527136788005009E-15, ) AFF: 0 It leads to disabled TabelRate shipping method. Such value is calculated in Magento\OfflineShipping\Model\Carrier\Tablerate::collectRates(). Smth like: 29.95 - 10 - 19 - .95 = -3.5527136788005009E-15 and normally should be rounded before comparison. See http://php.net/manual/en/language.types.float.php
Contributor
|
Hi @mageprince. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#13831
Description
In free shipping flow sometimes you can get such query to DB:
It leads to disabled TabelRate shipping method. Such value is calculated in
Magento\OfflineShipping\Model\Carrier\Tablerate::collectRates().Smth like:and normally should be rounded before comparison. See http://php.net/manual/en/language.types.float.php
Manual testing scenarios