Skip to content

[Backport] Issues 13769. Fix wrong info about sent email in order sender.#17087

Merged
magento-engcom-team merged 1 commit intomagento:2.1-developfrom
mageprince:2.1-develop-PR-port-13878
Jul 26, 2018
Merged

[Backport] Issues 13769. Fix wrong info about sent email in order sender.#17087
magento-engcom-team merged 1 commit intomagento:2.1-developfrom
mageprince:2.1-develop-PR-port-13878

Conversation

@mageprince
Copy link
Copy Markdown
Contributor

Original Pull Request

#13878

Description

Fixes wrong info about sent email in Order Sender. Order sender when send method got exception then checkAndSend should return false.

Fixed Issues (if relevant)

  1. Order Email Sender #13769: Order Email Sender

Manual testing scenarios

  1. If we want check issue we should have wrong config sendmail in server.
  2. We should place order.
  3. We had wrong configuration in sendmail, so email not sent.
  4. In database in sales_order we should have email_send and send_email as false.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @mageprince. Thank you for your contribution.
We will aim to release these changes as part of 2.1.15.
Please check the release notes for final confirmation.

@mageprince mageprince deleted the 2.1-develop-PR-port-13878 branch July 26, 2018 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants