Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] FIXED - appended payment code to ID field to make it unique #16993

Conversation

ihor-sviziev
Copy link
Contributor

Original Pull Request

#15344

Description

Fixed Issues (if relevant)

  1. In payment step of checkout I cannot unselect #billing-save-in-address-book checkbox in non-first payment method #13692: In payment step of checkout I cannot unselect #billing-save-in-address-book checkbox in non-first payment method

Manual testing scenarios

  1. Log in to your client account.
  2. Add product to cart.
  3. Go to checkout and click next button to be able to choose payment methods.
  4. Open payment method other than the first one.
  5. Uncheck My billing and shipping address are the same checkbox
  6. Choose New address on the billing address dropdown
  7. Fill address
  8. Click on label Save in address book

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants