Skip to content

fix: remove disabled attribute on region list#16955

Merged
magento-engcom-team merged 1 commit into2.2-developfrom
unknown repository
Aug 8, 2018
Merged

fix: remove disabled attribute on region list#16955
magento-engcom-team merged 1 commit into2.2-developfrom
unknown repository

Conversation

@DanielRuf
Copy link
Copy Markdown
Contributor

Description

By default when a list is not populated at the beginning (eg for UK) and when we switch to another country (eg Germany) and get a populated list, the list is still disabled and we can not select any option.

Fixed Issues (if relevant)

  1. ...

Manual testing scenarios

  1. go to /customer/account/create/
  2. switch from a country with an empty region list to a country with a region list
  3. try to select a region (does not work as the input is still disabled)

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @DanielRuf. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@DanielRuf
Copy link
Copy Markdown
Contributor Author

@magento-engcom-team give me 2.2.5 instance

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @DanielRuf. Thank you for your request. I'm working on Magento 2.2.5 instance for you

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @DanielRuf, here is your Magento instance.
Admin access: https://i-16955-2-2-5.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @DanielRuf. Thank you for your contribution.
We will aim to release these changes as part of 2.2.7.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@DanielRuf DanielRuf deleted the fix/remove-disabled-attribute-on-region-list branch August 8, 2018 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants