Skip to content

Fixing annotations for some methods.#16899

Merged
magento-engcom-team merged 1 commit into
magento:2.2-developfrom
tiagosampaio:2.2-develop-001
Jul 23, 2018
Merged

Fixing annotations for some methods.#16899
magento-engcom-team merged 1 commit into
magento:2.2-developfrom
tiagosampaio:2.2-develop-001

Conversation

@tiagosampaio
Copy link
Copy Markdown
Member

@tiagosampaio tiagosampaio commented Jul 17, 2018

Simple changes to annotations by adding throws, etc.

Description

It's self explanatory.

Fixed Issues (if relevant)

  1. Not relevant.

Manual testing scenarios

No need of testing scenarios.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @tiagosampaio. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @tiagosampaio. Thank you for your contribution.
We will aim to release these changes as part of 2.2.6.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@tiagosampaio tiagosampaio deleted the 2.2-develop-001 branch August 7, 2018 12:58
@tiagosampaio tiagosampaio restored the 2.2-develop-001 branch October 18, 2018 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants