Update nginx.config.sample to exclude php5-fpm#16883
Conversation
M2.2.x is not compatible with php5.x so there's no reason to include it as an option in the nginx.config.sample
|
Hi @sean-wcb. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
|
Thanks for your contribution @sean-wcb! I'll process this one and let you know if we have any questions. |
|
Hi @miguelbalparda, thank you for the review. |
|
@sean-wcb thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
|
Hi @sean-wcb. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Description
M2.2.x is not compatible with php5.x so there's no reason to include it as an option in the nginx.config.sample. Refer to: https://devdocs.magento.com/guides/v2.2/install-gde/system-requirements-tech.html
Fixed Issues (if relevant)
This does not fix any issues. However, it does prevent someone from thinking that M2.2.x is compatible with php5.
Manual testing scenarios
No tests needed.
Contribution checklist