[Backport] Create ability to set is_visible_on_front to order status history comment#16846
Merged
magento-engcom-team merged 2 commits intomagento:2.1-developfrom Jul 16, 2018
ronak2ram:2.1-develop-PR-port-15637
Merged
[Backport] Create ability to set is_visible_on_front to order status history comment#16846magento-engcom-team merged 2 commits intomagento:2.1-developfrom ronak2ram:2.1-develop-PR-port-15637
magento-engcom-team merged 2 commits intomagento:2.1-developfrom
ronak2ram:2.1-develop-PR-port-15637
Conversation
magento-engcom-team
pushed a commit
that referenced
this pull request
Jul 16, 2018
…order status history comment #16846
Contributor
|
Hi @ronak2ram. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#15637
Create ability to set is_visible_on_front to order status history comment.
Description
The parameter
is_visible_on_frontis able to be set from the admin, but not fromaddStatusHistoryCommentof the order model. This would provide the ability to set this value from custom code such as event observers.Manual testing scenarios
->addStatusHistoryComment($comment, false)to not set is_visible_on_front (backwards compatible with no extra param)->addStatusHistoryComment($comment, false, true)to set is_visible_on_front->addStatusHistoryComment($comment, false, false)to not set is_visible_on_frontContribution checklist