[Backport] FIX for apparently random API failures while using array types#16828
Merged
magento-engcom-team merged 1 commit intomagento:2.1-developfrom Jul 17, 2018
ronak2ram:2.1-develop-PR-port-16137
Merged
[Backport] FIX for apparently random API failures while using array types#16828magento-engcom-team merged 1 commit intomagento:2.1-developfrom ronak2ram:2.1-develop-PR-port-16137
magento-engcom-team merged 1 commit intomagento:2.1-developfrom
ronak2ram:2.1-develop-PR-port-16137
Conversation
… webapi Interface class was using CR+LF end-of-line, TypeProcessor class was not able to determine the class name when an array was used.
magento-engcom-team
pushed a commit
that referenced
this pull request
Jul 17, 2018
…using array types #16828
Contributor
|
Hi @ronak2ram. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#16137
Description
Magento2 web-api is based on the Interface doctype, but if the developer is using CR+LF end-of-line, the
\Magento\Framework\Reflection\TypeProcessorclass is not able to determine the class name on array types.This was caused by a wrong regex non including
\rin\Magento\Framework\Reflection\TypeProcessor::getParamType.Additional note: Magento 2.2-develop seems to be not affected by this.
Contribution checklist