[Backport] Fulltext replacement with like condition#16827
Closed
ronak2ram wants to merge 1 commit intomagento:2.2-developfrom
ronak2ram:2.2-develop-PR-port-15685
Closed
[Backport] Fulltext replacement with like condition#16827ronak2ram wants to merge 1 commit intomagento:2.2-developfrom ronak2ram:2.2-develop-PR-port-15685
ronak2ram wants to merge 1 commit intomagento:2.2-developfrom
ronak2ram:2.2-develop-PR-port-15685
Conversation
…lied to a DB collection. See magento/inventory#1221
Contributor
|
Hi @ronak2ram. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
sidolov
requested changes
Jul 15, 2018
Contributor
sidolov
left a comment
There was a problem hiding this comment.
Please, cover changes with unit test
Contributor
|
@ronak2ram , I am closing this PR now due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#15685
Fulltext replacement with like condition when a SearchCriteria is app…lied to a DB collection.
See magento/inventory#1221
Description
When a search criteria is run over a MySQL based entty, the condition is improperly translated with
eqcondition.Translating with a
likecondition is much more similar to a fulltext.See magento/inventory#1221
See magento/inventory#1285
Fixed Issues (if relevant)
Contribution checklist