Skip to content

[Forwardport] Fixed condition with usage isPost method#16823

Merged
magento-engcom-team merged 2 commits intomagento:2.3-developfrom
gelanivishal:2.3-develop-PR-port-12626
Aug 10, 2018
Merged

[Forwardport] Fixed condition with usage isPost method#16823
magento-engcom-team merged 2 commits intomagento:2.3-developfrom
gelanivishal:2.3-develop-PR-port-12626

Conversation

@gelanivishal
Copy link
Copy Markdown
Contributor

@gelanivishal gelanivishal commented Jul 15, 2018 •
edited by sidolov
Loading

Original Pull Request

#12626

  • removed private function isPost
  • removed unused imports
  • added request method isPost
  • added interface that expands HTTP request class

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@pusachev @gelanivishal
Fixed condition with usage isPost method
db6f027 
- removed private function isPost
- removed unused imports
- added request method isPost
- added interface that expands HTTP request class
- fixed unit test in Contact module
- fixed integration tests in Contact module
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Jul 15, 2018

Hi @gelanivishal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ihor-sviziev ihor-sviziev self-assigned this Jul 16, 2018
ihor-sviziev
ihor-sviziev requested changes Jul 16, 2018
View reviewed changes
Comment thread lib/internal/Magento/Framework/App/HttpRequestInterface.php
* See COPYING.txt for license details.
*/

namespace Magento\Framework\App;
Copy link
Copy Markdown
Contributor

@ihor-sviziev ihor-sviziev Jul 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please define strict type declaration for this file

@ihor-sviziev
Copy link
Copy Markdown
Contributor

ihor-sviziev commented Jul 20, 2018 •
edited
Loading

Hi @gelanivishal I fixed this issue myself. Let's wait when Travis will run all tests again

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jul 20, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Jul 20, 2018

Hi @ihor-sviziev, thank you for the review.
ENGCOM-2431 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 8a85400 into magento:2.3-develop Aug 10, 2018
magento-engcom-team pushed a commit that referenced this pull request Aug 10, 2018
ENGCOM-2431: [Forwardport] Fixed condition with usage isPost method #…
78f9d7a 
…16823
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Aug 10, 2018

Hi @gelanivishal. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

Labels

Component: Contact Component: Framework/App Release Line: 2.3

Projects

None yet

Milestone

Release: 2.3.0

Development

Successfully merging this pull request may close these issues.

4 participants

@gelanivishal @magento-engcom-team @ihor-sviziev @pusachev