[Forwardport] #15588 Fixed incorrect image urls in multistore xml sitemap#16813
Merged
magento-engcom-team merged 7 commits intomagento:2.3-developfrom Aug 10, 2018
mage2pratik:2.3-develop-PR-port-15689
Merged
[Forwardport] #15588 Fixed incorrect image urls in multistore xml sitemap#16813magento-engcom-team merged 7 commits intomagento:2.3-developfrom mage2pratik:2.3-develop-PR-port-15689
magento-engcom-team merged 7 commits intomagento:2.3-developfrom
mage2pratik:2.3-develop-PR-port-15689
Conversation
48 | ERROR | [x] Opening parenthesis of a multi-line function call must be the last content on the line
Change for travisCI
placed the stop Emulation in a finally. Now it will always be executed.
Contributor
|
Hi @mage2pratik. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
magento-engcom-team
pushed a commit
that referenced
this pull request
Aug 10, 2018
…store xml sitemap #16813
Contributor
|
Hi @mage2pratik. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#15689
Description
Added the appEmulation to get the correct image Url for the generated sitemaps. This was needed because the catalog image helper context had incorrect Url data.
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist