[Backport] Issue 15467 where a configuration sku gets deleted but is still saved…#16812
Merged
magento-engcom-team merged 2 commits intomagento:2.1-developfrom Jul 19, 2018
mage2pratik:2.1-develop-PR-port-15468
Merged
[Backport] Issue 15467 where a configuration sku gets deleted but is still saved…#16812magento-engcom-team merged 2 commits intomagento:2.1-developfrom mage2pratik:2.1-develop-PR-port-15468
magento-engcom-team merged 2 commits intomagento:2.1-developfrom
mage2pratik:2.1-develop-PR-port-15468
Conversation
… in a customer cart
magento-engcom-team
pushed a commit
that referenced
this pull request
Jul 19, 2018
…leted but is still saved… #16812
Contributor
|
Hi @mage2pratik. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#15468
#15467
Reproduce: Add a configuration product to your cart logged in as a customer. Log out.
Have an admin delete the product SKU from the configuration product.
Customer: login to your cart from checkout (add something to your cart logged out and login with the modal window).
You will get an error about getThumbnail() on a null object. This commit fixes the issue in two files.