[Backport] Remove double semicolon from the style sheets.#16809
Merged
magento-engcom-team merged 2 commits intomagento:2.1-developfrom Jul 26, 2018
Merged
Conversation
Contributor
|
@gelanivishal , please, make the same changes as an original PR, currently, your PR contains extra changes. |
Contributor
Author
|
@sidolov There is coding standard changes. I have just removed extra space and tab issue. Please check it. Thank you. |
Contributor
Author
|
@sidolov Have you checked my message? Thank you. |
Contributor
|
Hi @gelanivishal , please, sort all CSS properties alphabetically according to our LESS coding standards |
Contributor
Author
|
@sidolov Is there any online tool? |
Contributor
|
@gelanivishal , unfortunately, our team doesn't provide any tools for that case. You may find the tool by yourself or fix issues manually. |
Contributor
Author
|
@sidolov Please review the latest commit. |
magento-engcom-team
added
Release Line: 2.1
Area: Lib/Frontend
Progress: accept
and removed
Progress: needs update
labels
magento-engcom-team
pushed a commit
that referenced
this pull request
Jul 26, 2018
Contributor
|
Hi @gelanivishal. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#15795
Description
Remove double semicolon from the style sheets.
Fixed Issues (if relevant)
N/A
Manual testing scenarios
N/A
Contribution checklist