Skip to content

[Backport] magento/magento2#16184: Fix type error in payment void method#16801

Merged
magento-engcom-team merged 1 commit into
magento:2.1-developfrom
gelanivishal:2.1-develop-PR-port-16194
Jul 19, 2018
Merged

[Backport] magento/magento2#16184: Fix type error in payment void method#16801
magento-engcom-team merged 1 commit into
magento:2.1-developfrom
gelanivishal:2.1-develop-PR-port-16194

Conversation

@gelanivishal
Copy link
Copy Markdown
Contributor

@gelanivishal gelanivishal commented Jul 14, 2018

Description

Fixes TypeError for void() method in Directpost payment method of Authorizenet module.

The method expects an argument of DataObject type but instead none is given. Passing the response object fixes the problem.

Fixed Issues (if relevant)

  1. Argument 1 passed to Magento\Sales\Model\Order\Payment must be an instance of Magento\Framework\DataObject, none given #16184: Argument 1 passed to Magento\Sales\Model\Order\Payment must be an instance of Magento\Framework\DataObject, none given

Manual testing scenarios

  1. Setup authorizenet
  2. Setup a plugin that uses declineOrder method of the Directpost model
  3. Checkout with authorizenet

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Original PR

#16194

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @gelanivishal. Thank you for your contribution.
We will aim to release these changes as part of 2.1.15.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants