Avoid undefined index warning when using uppercase reserved word#16785
Conversation
|
Hi @FreekVandeursen. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
orlangur
left a comment
There was a problem hiding this comment.
Just checked the full method code, looks pretty strange to me, like it was never used in action. Thanks for the fix!
|
Hi @orlangur, thank you for the review. |
|
Hi @FreekVandeursen. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
ReservedWordsSniff will trigger an undefined index error if a reserved word is used in uppercase.
Manual testing scenarios
Expected result
Code sniffer error "Cannot use "Bool" in namespace as it is reserved since PHP 7"
Actual result
Code sniffer error "An error occurred during processing; checking has been aborted. The error message was: Undefined index: Bool"