You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the MSI modules all fixtures for tests are in <Module_Name>/Test/_data which is different from Magento current implementations.
In order to avoid falling copy paste detector tests on the fixtures has been added a new rule to the blacklist.
Hi @VitaliyBoyko. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:
@magento-engcom-team give me test instance - deploy test instance based on PR changes
@magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance
VitaliyBoyko
changed the title
[Backport 2.3] MSI-1411: Add new rule to copy paste detector blacklist
[Backport 2.2] MSI-1411: Add new rule to copy paste detector blacklist
Jul 11, 2018
Hi @VitaliyBoyko, thanks for collaboration. These changes are not necessary for 2.2-develop branch. In 2.2-develop all tests placed ins dev/tests folder and we have not the plan to change this in the 2.2 version.
I've created this PR just after discussion with @orlangur and @ishakhsuvarov in original PR conversation.
Just to remind and make sure that all points are included: @orlangur
It is important to have in 2.3 rules which are equally or more strict than in 2.2 for various static tests. If we won't port it into 2.2 somebody may need to perform an unneeded refactoring of fixture not knowing it is simply ignored in 2.3.
Not that I am against porting this solution. I am just not seeing a point in requiring this PR to be merged in 2.2 first.
Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR: #16508
Description
In the MSI modules all fixtures for tests are in <Module_Name>/Test/_data which is different from Magento current implementations.
In order to avoid falling copy paste detector tests on the fixtures has been added a new rule to the blacklist.