Skip to content

[Backport 2.2] MSI-1411: Add new rule to copy paste detector blacklist#16725

Closed
VitaliyBoyko wants to merge 1 commit intomagento:2.2-developfrom
VitaliyBoyko:MSI-1411-add-new-rule-to-copy-paste-detector-blacklist-mage-22
Closed

[Backport 2.2] MSI-1411: Add new rule to copy paste detector blacklist#16725
VitaliyBoyko wants to merge 1 commit intomagento:2.2-developfrom
VitaliyBoyko:MSI-1411-add-new-rule-to-copy-paste-detector-blacklist-mage-22

Conversation

@VitaliyBoyko
Copy link
Copy Markdown
Contributor

Original PR: #16508

Description

In the MSI modules all fixtures for tests are in <Module_Name>/Test/_data which is different from Magento current implementations.
In order to avoid falling copy paste detector tests on the fixtures has been added a new rule to the blacklist.

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jul 11, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @VitaliyBoyko. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VitaliyBoyko VitaliyBoyko changed the title [Backport 2.3] MSI-1411: Add new rule to copy paste detector blacklist [Backport 2.2] MSI-1411: Add new rule to copy paste detector blacklist Jul 11, 2018
@VladimirZaets VladimirZaets self-assigned this Jul 11, 2018
@VladimirZaets
Copy link
Copy Markdown
Contributor

Hi @VitaliyBoyko, thanks for collaboration. These changes are not necessary for 2.2-develop branch. In 2.2-develop all tests placed ins dev/tests folder and we have not the plan to change this in the 2.2 version.

@VitaliyBoyko
Copy link
Copy Markdown
Contributor Author

VitaliyBoyko commented Jul 12, 2018

I've created this PR just after discussion with @orlangur and @ishakhsuvarov in original PR conversation.
Just to remind and make sure that all points are included:
@orlangur

It is important to have in 2.3 rules which are equally or more strict than in 2.2 for various static tests. If we won't port it into 2.2 somebody may need to perform an unneeded refactoring of fixture not knowing it is simply ignored in 2.3.

@ishakhsuvarov

Not that I am against porting this solution. I am just not seeing a point in requiring this PR to be merged in 2.2 first.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants