[Backport] Fix for #12081: missing translations in the js-translations.json#16720
Merged
magento-engcom-team merged 1 commit intomagento:2.1-developfrom Jul 12, 2018
Conversation
magento-engcom-team
pushed a commit
that referenced
this pull request
Jul 12, 2018
…s-translations.json #16720
Contributor
|
Hi @sanganinamrata. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#13528
Description
This PR adds an additional pattern to the module responsible for generating the js-translations.json file. The translation routine doesn't translate strings in tags like
<translate args="This won't be translated".This is related to (but doesn't fix) #13471 where the Html parser of the phrase collection module is also missing a pattern matching the
<translate args=tags.Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist