Update regex in ControllerAclTest#16707
Merged
Merged
Conversation
Change regex in ControllerAclTest::getControllerPath() to avoid classes which are under a namespace with a "Controller" part (like for example controller plugins) being interpreted as controllers causing the Act test to fail.
Contributor
|
Hi @aleron75. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
orlangur
approved these changes
Jul 11, 2018
Contributor
|
Hi @orlangur, thank you for the review. |
Contributor
magento-engcom-team
pushed a commit
that referenced
this pull request
Jul 23, 2018
Contributor
|
Hi @aleron75. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
This was referenced Jul 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change regex in
ControllerAclTest::getControllerPath()to avoid classes which are under a namespace with a "Controller" part (like for example controller plugins) being interpreted as controllers causing the Act test to fail.I need this change because, in the scope of MSI development, I have to define the following plugin for a controller:
The
Magento\InventoryCatalog\Plugin\Catalog\Controller\Adminhtml\Product\Initialization\StockDataFilter\AllowNegativeMinQtyPluginplugin class makes the test fail because it is considered a controller but doesn't extend\Magento\Backend\App\AbstractAction.Manual testing scenarios
ControllerAclTeststatic test