[Forwardport] Fix false cache_lifetime usage in xml layouts#16627
Closed
mageprince wants to merge 1 commit intomagento:2.3-developfrom
mageprince:2.3-develop-PR-port-16086
Closed
[Forwardport] Fix false cache_lifetime usage in xml layouts#16627mageprince wants to merge 1 commit intomagento:2.3-developfrom mageprince:2.3-develop-PR-port-16086
mageprince wants to merge 1 commit intomagento:2.3-developfrom
mageprince:2.3-develop-PR-port-16086
Conversation
Contributor
|
Hi @mageprince. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
orlangur
approved these changes
Jul 9, 2018
Contributor
|
Hi @orlangur, thank you for the review. |
Contributor
|
Hi @mageprince , please, take a look at failed tests |
Contributor
|
@mageprince , I am closing this PR now due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#16086
Fix cache_lifetime usage with false value
Description
Fix
<argument name="cache_lifetime" xsi:type="boolean">false</argument>Usage eg in
Magento/Swatches/view/frontend/layout/checkout_cart_configure_type_configurable.xml
Fixed Issues (if relevant)
Manual testing scenarios
Reproduced in 2.2 and 2.1 version
Expected result
Configurable product options should be preselected
Actual result:
Configurable product options are not preselected
It happens because there is a check in
View/Element/AbstractBlock.php
protected function _loadCache() { if ($this->getCacheLifetime() === null || !$this->_cacheState->isEnabled(self::CACHE_GROUP)) { return false; }Contribution checklist