Skip to content

[Forwardport] M2.2.4 missing meta title tag and doesn't show#16608

Closed
gelanivishal wants to merge 3 commits intomagento:2.3-developfrom
gelanivishal:2.3-develop-PR-port-15532
Closed

[Forwardport] M2.2.4 missing meta title tag and doesn't show#16608
gelanivishal wants to merge 3 commits intomagento:2.3-developfrom
gelanivishal:2.3-develop-PR-port-15532

Conversation

@gelanivishal
Copy link
Copy Markdown
Contributor

@gelanivishal gelanivishal commented Jul 7, 2018

Original Pull Request

#15532

FIX for issue #15501 - M2.2.4 missing meta title tag and doesn't show product name if meta title is empty

Description

The current Magento behaviour does not allow to specify a title meta tag and the "Meta Title" option in the product's page is binded to the page's title.

This PR adds the meta tile tag and allows to use title and meta title independently.

Fixed Issues (if relevant)

  1. M2.2.4 missing meta title tag and doesn't show product name if meta title is empty #15501: M2.2.4 missing meta title tag and doesn't show product name if meta title is empty

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @gelanivishal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@miguelbalparda miguelbalparda self-assigned this Jul 9, 2018
@ishakhsuvarov ishakhsuvarov removed their assignment Jul 12, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-2378 has been created to process this Pull Request

protected function processMetadataContent($name, $content)
{
$method = 'get' . $this->string->upperCaseWords($name, '_', '');
if ($name === 'title') {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like additional logic for title attribute should be here, please, revert.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sidolov Do you want to keep old logic for 2.3 ?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gelanivishal , yes, this logic should be here due to bugfix

@miguelbalparda
Copy link
Copy Markdown
Contributor

I am closing this PR now due to inactivity. Feel free to reopen and update if you wish to continue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants