[Backport] Declare module namespace before template path name(Magento_Sales::order/creditmemo.phtml).#16586
Merged
magento-engcom-team merged 1 commit intomagento:2.1-developfrom Jul 6, 2018
mageprince:2.1-develop-PR-port-16481
Merged
[Backport] Declare module namespace before template path name(Magento_Sales::order/creditmemo.phtml).#16586magento-engcom-team merged 1 commit intomagento:2.1-developfrom mageprince:2.1-develop-PR-port-16481
magento-engcom-team merged 1 commit intomagento:2.1-developfrom
mageprince:2.1-develop-PR-port-16481
Conversation
magento-engcom-team
pushed a commit
that referenced
this pull request
Jul 6, 2018
… name(Magento_Sales::order/creditmemo.phtml). #16586
Contributor
|
Hi @mageprince. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#16481
Description
When we override block creditmemo(Magento\Sales\Block\Order\Creditmemo) to my custom module.
It throws an error and finding order/creditmemo.phtml in my custom module.
I tried to extend Block Magento\Sales\Block\Order\Creditmemo from my custom module.
Fixed Issues (if relevant)
protected $_template = 'Magento_Sales::order/creditmemo.phtml';Manual testing scenarios
Contribution checklist