Skip to content

Properly hyphenate "third-party"#16546

Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
ronak2ram:2.3-ronak-patch
Jul 7, 2018
Merged

Properly hyphenate "third-party"#16546
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
ronak2ram:2.3-ronak-patch

Conversation

@ronak2ram
Copy link
Copy Markdown
Member

@ronak2ram ronak2ram commented Jul 4, 2018

Description

Remaining to changes in Magento 2.3.

Fixed Issues (if relevant)

  1. magento/magento2Properly hyphenate "third-party" #16489 : Properly hyphenate "third-party"

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Original PR

#16489

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @ronak2ram. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets
Copy link
Copy Markdown
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @VladimirZaets. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @VladimirZaets, here is your new Magento instance.
Admin access: https://pr-16546.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Please make sure you are PR author or assignee to access the instance.

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @ronak2ram. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants