Skip to content

[Forwardport] Admin controller product set save refactor#16504

Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
AnshuMishra17:2.3-develop-PR-port-16217
Jul 7, 2018
Merged

[Forwardport] Admin controller product set save refactor#16504
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
AnshuMishra17:2.3-develop-PR-port-16217

Conversation

@AnshuMishra17
Copy link
Copy Markdown
Contributor

Original Pull Request

#16217
Description
Remove direct use of object manager for admin attribute set save controller using constructor based dependency injection.

Manual testing scenarios
Created a new attribute set in admin under Stores -> Attribute Set -> Add Attribute Set.
Edit an existing attribute set under Stores -> Attribute Set

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @AnshuMishra17. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @AnshuMishra17. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants