Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Jul 3, 2018

Description

Solution for Magento 2.2.5 : Admin user is not able to login with customer group user role #16501.

It's because of ACL issue. 'Customer group should be in 'Magento_Customer::customer' instead of 'Magento_Backend::stores_other_settings'.

Fixed Issues (if relevant)

  1. Magento 2.2.5 : Admin user is not able to login with customer group user role #16501: Magento 2.2.5 : Admin user is not able to login with customer group user role.

Manual testing scenarios

  1. System > Permission > User Roles.
  2. Create a user role with 'customer group' permission.
  3. Login with new user credential.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jul 3, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ emiprotech
❌ Tejas


Tejas seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@magento-engcom-team
Copy link
Contributor

Hi @emiprotech. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@dmanners
Copy link
Contributor

Hi @emiprotech there are two committers to this PR could you please make sure that both have signed the CLA or make both commits come from the same github user. Once that is done I would be happy to progress this PR.

Thanks

@dmanners dmanners self-assigned this Aug 13, 2018
@ghost
Copy link
Author

ghost commented Aug 13, 2018

Hello @dmanners ,
Thank you for information , let me close it and create again pull request.

@ghost ghost closed this Aug 13, 2018
@ghost ghost deleted the issue-16501 branch August 13, 2018 11:30
@ghost
Copy link
Author

ghost commented Aug 13, 2018

Hi @dmanners ,
Actually after update repository , files changes are applied in repository.
changes are merged by this pull request .#17515

@dmanners
Copy link
Contributor

Oh nice, thanks for the update @emiprotech and your time spent on this issue.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants