Skip to content

[FIX] dev:di:info duplicates plugin info #16474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magento-engcom-team merged 2 commits into from
Jul 9, 2018
Merged

[FIX] dev:di:info duplicates plugin info #16474

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c0372b
[FIX] dev:di:info duplicates plugin info
coderimus Jul 1, 2018
3f70b11
Fix according review - change how we manage that plugin in a property…
coderimus Jul 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions app/code/Magento/Developer/Model/Di/PluginList.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,8 @@ private function addPluginToList($pluginInstance, $pluginMethod, $methodTypes, $
{
if ($methodTypes & $typeCode) {
if (!array_key_exists($pluginInstance, $this->pluginList[$this->pluginTypeMapping[$typeCode]])) {
$this->pluginList[$this->pluginTypeMapping[$typeCode]][$pluginInstance] = [];
$this->pluginList[$this->pluginTypeMapping[$typeCode]][$pluginInstance][] = $pluginMethod;
}
$this->pluginList[$this->pluginTypeMapping[$typeCode]][$pluginInstance][] = $pluginMethod ;

@orlangur orlangur Jul 1, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

$this->pluginList[$this->pluginTypeMapping[$typeCode]][$pluginInstance][] = $pluginMethod ; ->

$this->pluginList[$this->pluginTypeMapping[$typeCode]][$pluginInstance][$pluginMethod] = 1

Please avoid duplication by reversing array. Please check if it is possible to remove if while avoiding PHP notice.

}
}
}