[Forwardport] Add missing showInStore attributes#16459
Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom Jul 5, 2018
Merged
[Forwardport] Add missing showInStore attributes#16459magento-engcom-team merged 1 commit intomagento:2.3-developfrom
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
Conversation
Add missing showInStore attributes on Braintree configuration as there are some values that are changeable on store view (Title, Descriptors, merchant name override) and are not accessible from store view level.
Contributor
|
Hi @aschrammel. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
4 tasks
orlangur
approved these changes
Jul 4, 2018
Contributor
|
Hi @orlangur, thank you for the review. |
magento-engcom-team
pushed a commit
that referenced
this pull request
Jul 5, 2018
Contributor
|
Hi @aschrammel. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add missing
showInStoreattributes on Braintree configuration as there are some values that are changeable on store view (title, descriptors, merchant name override) and are not accessible from store view level due to the missing store view level permission for the containing group.Braintree configuration offers the possibility to change following fields on store view level:
All the fields are correctly shown in default config and on website level, but when changing to storeview, nothing is shown at all when expanding Braintree section.
Fixed Issues (if relevant)
Manual testing scenarios
After applying the PR, the above mentioned fields in their respective groups are shown.
Contribution checklist
Original PR
#16458