Skip to content

[Forwardport] Login with wishlist raise report after logout. #16387

Merged
magento-engcom-team merged 2 commits intomagento:2.3-developfrom
swnsma:login-with-wishlist-report-after-logout
Jul 3, 2018
Merged

[Forwardport] Login with wishlist raise report after logout. #16387
magento-engcom-team merged 2 commits intomagento:2.3-developfrom
swnsma:login-with-wishlist-report-after-logout

Conversation

@swnsma
Copy link
Copy Markdown
Contributor

@swnsma swnsma commented Jun 25, 2018

Description

Fix login issue through wishlist url which raise error right after login and report after logout.

Fixed Issues (if relevant)

  1. magento/magento2#?: can not found any issue on github, related to this error.

Manual testing scenarios

Pre-conditions

  1. Empty Magento.
  2. Registered customer.

Steps to reproduce

  1. Go to frontend.
  2. Go to route /wishlist
  3. You will be redirected to login form.
  4. Login to your customer account.
  5. Logout from the account.

Actual results

  1. You can see error after login.
  2. You will see report screen each time you will try to logout.

Expected results

  1. You can see no error after login.
  2. You successfully logout.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Original PR

#16386

- fix error message after login with wishlist;
- fix possibility to logout after login with wishlist;
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @swnsma. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@swnsma swnsma added the Partner: ISM eCompany Pull Request is created by partner ISM eCompany label Jun 25, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jun 26, 2018
@swnsma swnsma changed the title [Forwardport] Login with wishlist raise report after logout [Forwardport] magento/magento2#15505: Interceptor class methods do not support nullable return types Jun 27, 2018
@swnsma swnsma changed the title [Forwardport] magento/magento2#15505: Interceptor class methods do not support nullable return types [Forwardport] Login with wishlist raise report after logout. Jun 27, 2018
@magento-engcom-team magento-engcom-team merged commit d8e87dc into magento:2.3-develop Jul 3, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @swnsma. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

@swnsma swnsma deleted the login-with-wishlist-report-after-logout branch July 6, 2018 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants