Skip to content

Wishlist update item issue#16372

Merged
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
eduard13:2.2-develop-update-wishlist-item
Jul 3, 2018
Merged

Wishlist update item issue#16372
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
eduard13:2.2-develop-update-wishlist-item

Conversation

@eduard13
Copy link
Copy Markdown
Contributor

@eduard13 eduard13 commented Jun 24, 2018

Description

This PR fixes removing the wishlist item from wishlist while updating it, if instead of id it is sent \Magento\Wishlist\Model\Item object.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jun 24, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Copy link
Copy Markdown
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice observation! 👍

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @eduard13. Thank you for your contribution.
We will aim to release these changes as part of 2.2.6.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@eduard13 eduard13 deleted the 2.2-develop-update-wishlist-item branch August 13, 2018 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Wishlist Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Release Line: 2.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants