Magento_Sales integration tests: fix invoice_list fixture var tags#16350
Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom Jun 26, 2018
evktalo:fix-invoice_list-var-tags
Merged
Magento_Sales integration tests: fix invoice_list fixture var tags#16350magento-engcom-team merged 1 commit intomagento:2.3-developfrom evktalo:fix-invoice_list-var-tags
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
evktalo:fix-invoice_list-var-tags
Conversation
Contributor
|
Hi @evktalo. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
orlangur
approved these changes
Jun 23, 2018
Contributor
|
Hi @orlangur, thank you for the review. |
Contributor
Contributor
|
Hi @evktalo! Any contributions should be applied to |
Contributor
|
Hi @evktalo. Thank you for your contribution. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the invoice_list fixture for Magento/Sales integration tests, the var tags changed in this pull request refer to non-existing variables and the other has a wrong type.
Fixed Issues (if relevant)
None.
Manual testing scenarios
Contribution checklist