Skip to content

[Forwardport] [Correct code formatting]#16321

Merged
magento-engcom-team merged 4 commits intomagento:2.3-developfrom
hitesh-wagento:2.3-develop-code-improvement-new
Jun 25, 2018
Merged

[Forwardport] [Correct code formatting]#16321
magento-engcom-team merged 4 commits intomagento:2.3-developfrom
hitesh-wagento:2.3-develop-code-improvement-new

Conversation

@hitesh-wagento
Copy link
Copy Markdown
Contributor

@hitesh-wagento hitesh-wagento commented Jun 22, 2018

Original Pull Request

#15811

This PR is a:

  • Bug fix or improvement

Summary

Correct Code formatting.

Additional information

NA

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Area: Design/Frontend labels Jun 22, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @hitesh-wagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@hitesh-wagento
Copy link
Copy Markdown
Contributor Author

Hi @VladimirZaets

I have seen below time out error in Travis
The job exceeded the maximum time limit for jobs, and has been terminated.

Could you please check once what cause failed travis?

Thanks

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @hitesh-wagento. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

@hitesh-wagento hitesh-wagento deleted the 2.3-develop-code-improvement-new branch September 6, 2018 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Design/Frontend Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants