Admin tabs order not working properly#16175
Admin tabs order not working properly#16175magento-engcom-team merged 7 commits intomagento:2.2-developfrom tiagosampaio:hotfix/16174
Conversation
|
Hi @tiagosampaio. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
tiagosampaio
changed the title
|
@tiagosampaio thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
|
|
||
| if ($this->_activeTab === null) { | ||
| /** @var TabInterface $tab */ | ||
| foreach ($this->_tabs as $tab) { |
There was a problem hiding this comment.
Hi @tiagosampaio. You can select first array tab uses reset() and current() methods, please use theirs.
| /** | ||
| * @return array | ||
| */ | ||
| protected function reorderTabs() |
There was a problem hiding this comment.
Due to Magento backward-compatible guide we can't create new protected methods.
| * @return array | ||
| */ | ||
| protected function reorderTabs() | ||
| { |
There was a problem hiding this comment.
Please, divide code in this function to few separate private functions.
|
Hi @tiagosampaio, thank for fixes. Please, fix fails of the static tests |
|
@VladimirZaets I removed the multiple lines and committed again. |
|
Hi @tiagosampaio. Thanks for changes |
magento-engcom-team
added
Progress: needs update
Progress: accept
and removed
Progress: needs update
labels
|
Hi @tiagosampaio. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
4 participants
Description
When you add 2 or more tabs to admin area, like order view page, by using the method addTabAfter and the second new tab is placed after the first new tab the sort order does not work as expected.
More details in the issue.
Fixed Issues
Manual testing scenarios
Described in the issue.
Contribution checklist