fix: prevent inline-block issue in name form due to space and font-size

[DanielRuf]

Description

Fixed Issues (if relevant)

1. inline-block issue in name form #16047

Manual testing scenarios

1. open a page where the name form is eg /customer/account/edit/
2. compare the space between asterisk / required field indicator to other fields with the required field indicator

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[VladimirZaets]

Hi, @DanielRuf, I took your PR into processing, thank you for collaboration.

[magento-engcom-team]

Hi @DanielRuf. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

[hitesh-wagento]

Hi @DanielRuf

Could you please advice me why are you change Magento2 coding standard ?

Thanks

[DanielRuf]

Hi @DanielRuf

Could you please advice me why are you change Magento2 coding standard ?

Thanks

Sorry but I do not understand what you mean.

[DanielRuf]

Could you please advice me why are you change Magento2 coding standard ?

This is not a coding standard. Check the other fields. inline-block adds an empty space when you have a space in the HTML, which can be removed with hacks like font-size:0 or by removing spaces between the tags. The second approach is used in the other parts of the form and so this is consistent with the rest.

I did not change any coding standard.

[DanielRuf]

See https://css-tricks.com/fighting-the-space-between-inline-block-elements/

[hitesh-wagento]

Hi @DanielRuf

Thanks for clarification :)