Skip to content

[Forwardport] Correct return type of methods and typo correction#16044

Closed
chirag-wagento wants to merge 1 commit intomagento:2.3-developfrom
chirag-wagento:2.3-develop-PR-port-15993
Closed

[Forwardport] Correct return type of methods and typo correction#16044
chirag-wagento wants to merge 1 commit intomagento:2.3-developfrom
chirag-wagento:2.3-develop-PR-port-15993

Conversation

@chirag-wagento
Copy link
Copy Markdown
Contributor

@chirag-wagento chirag-wagento commented Jun 12, 2018

Original Pull Request

#15993

Description

Correct return type of methods and change return type.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@orlangur orlangur self-assigned this Jun 13, 2018
@orlangur orlangur added this to the Release: 2.3.0 milestone Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@orlangur orlangur

Labels

Component: CatalogRule Component: CatalogSearch Component: UrlRewrite Component: User Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: reject

Projects

None yet

Milestone

Release: 2.3.0

Development

Successfully merging this pull request may close these issues.

4 participants

@chirag-wagento @orlangur @magento-engcom-team @saurabh-parekh