Skip to content

[Forwardport] fix for dropdown toggle icon in cart#16042

Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
chirag-wagento:2.3-develop-PR-port-15991
Jun 13, 2018
Merged

[Forwardport] fix for dropdown toggle icon in cart#16042
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
chirag-wagento:2.3-develop-PR-port-15991

Conversation

@chirag-wagento
Copy link
Copy Markdown
Contributor

@chirag-wagento chirag-wagento commented Jun 12, 2018

Original Pull Request

#15991

Description

Fixed cart page sidebar dropdown icon symbol.

Manual testing scenarios

  1. Open cart page. Toggle discount or Tax dropdown.
    Expected: arrow down changes to arrow up.
    Currently: arrow down changes to arrow left.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Area: Design/Frontend labels Jun 12, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jun 12, 2018
@VladimirZaets
Copy link
Copy Markdown
Contributor

VladimirZaets commented Jun 12, 2018

Hi, @chiragp-wagento , I took your PR into processing, thank you for collaboration.

@magento-engcom-team magento-engcom-team merged commit f4b014d into magento:2.3-develop Jun 13, 2018
magento-engcom-team pushed a commit that referenced this pull request Jun 13, 2018
ENGCOM-1956: [Forwardport] fix for dropdown toggle icon in cart #16042
cea78f9
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Jun 13, 2018

Hi @chirag-wagento. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@VladimirZaets VladimirZaets

Labels

Area: Design/Frontend Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3

Projects

None yet

Milestone

Release: 2.3.0

Development

Successfully merging this pull request may close these issues.

4 participants

@chirag-wagento @VladimirZaets @magento-engcom-team @Karlasa