[Forwardport] Attribute set save admin controller refactor#16041
Closed
hitesh-wagento wants to merge 4 commits intomagento:2.3-developfrom
Closed
[Forwardport] Attribute set save admin controller refactor#16041hitesh-wagento wants to merge 4 commits intomagento:2.3-developfrom
hitesh-wagento wants to merge 4 commits intomagento:2.3-developfrom
Conversation
Fix static test failures
Fix static test failures
magento-engcom-team
added
Partner: Wagento
Contributor
|
Original PR was closed, instead was created new PR with all needed changes. #16217 I'm closing this PR as not actual anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#15990
Description
Remove direct use of object manager for admin attribute set save controller using constructor based dependency injection.
Manual testing scenarios
Created a new attribute set in admin under Stores -> Attribute Set -> Add Attribute Set.
Edit an existing attribute set under Stores -> Attribute Set