Wishlist: Remove unnecessary parameter from invoking toHtml() method#16022
Merged
magento-engcom-team merged 2 commits intomagento:2.3-developfrom Jun 13, 2018
Merged
Conversation
magento-engcom-team
added
Partner: Atwix
This was referenced Jun 11, 2018
Contributor
|
|
orlangur
approved these changes
Jun 12, 2018
ishakhsuvarov
added a commit
to rogyar/magento2
that referenced
this pull request
Jun 12, 2018
According to @orlangur suggestion in magento#16022
ishakhsuvarov
added a commit
to rogyar/magento2
that referenced
this pull request
Jun 12, 2018
According to @orlangur suggestion in magento#16022
magento-engcom-team
pushed a commit
that referenced
this pull request
Jun 13, 2018
Contributor
|
Hi @rogyar. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There's an extra parameter upon invoking the
toHtml()method in theWishlist/view/frontend/templates/item/list.phtmlfile. The original method call is the following:which is not correct since
toHtml()method of theMagento\Wishlist\Block\Customer\Wishlist\Item\Columnhas no additional parameters. The current PR removes the redundant parameter from invoking the method.Fixed Issues (if relevant)
N/A
Manual testing scenarios
N/A