Small refactoring to better code readability#16010
Merged
magento-engcom-team merged 2 commits intomagento:2.2-developfrom Jun 14, 2018
aitoc:small-refactoring-dependence
Merged
Small refactoring to better code readability#16010magento-engcom-team merged 2 commits intomagento:2.2-developfrom aitoc:small-refactoring-dependence
magento-engcom-team merged 2 commits intomagento:2.2-developfrom
aitoc:small-refactoring-dependence
Conversation
This was referenced Jun 12, 2018
orlangur
requested changes
Jun 12, 2018
| $dependsJson = $this->_getDependsJson(); | ||
| $configOptions = $this->_configOptions ? $this->_jsonEncoder->encode($this->_configOptions) : null; | ||
| $configOptionsStr = $configOptions ? ', ' . $configOptions : ''; | ||
| $paramsStr = $dependsJson . $configOptionsStr; |
Contributor
There was a problem hiding this comment.
IMO readability could be slightly improved if you do like this:
$params = $this->_getDependsJson();
if ($this->_configOptions) {
$params .= ', ' . $this->_configOptions;
}
Contributor
Author
There was a problem hiding this comment.
@orlangur, Absolutely agree with you. I updated pull request according to your suggestion.
orlangur
approved these changes
Jun 12, 2018
Contributor
|
Hi @orlangur, thank you for the review. |
Contributor
|
Hi @likemusic. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
This was referenced Jul 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Small refactoring to better code readability
Contribution checklist