Skip to content

fix: change "My Dashboard" to "My Account", fixes #16007#16009

Merged
magento-engcom-team merged 2 commits into2.2-developfrom
unknown repository
Jul 3, 2018
Merged

fix: change "My Dashboard" to "My Account", fixes #16007#16009
magento-engcom-team merged 2 commits into2.2-developfrom
unknown repository

Conversation

@DanielRuf
Copy link
Copy Markdown
Contributor

Description

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title
  2. ...

Manual testing scenarios

  1. ...
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@misha-kotov
Copy link
Copy Markdown

Hi @DanielRuf, do your changes affect both of these labels? Anywhere else?
image

@DanielRuf
Copy link
Copy Markdown
Contributor Author

So far these should at least affect the makred ones + title.

@DanielRuf
Copy link
Copy Markdown
Contributor Author

Should we also change "Account Dashboard" to "My Account"?

@VladimirZaets
Copy link
Copy Markdown
Contributor

@DanielRuf I think, yes
@misha-kotov can you please clarify all places where we should replace?
Thanks

@misha-kotov
Copy link
Copy Markdown

@DanielRuf the marked labels above + title sounds right to me. Are you saying there another "account dashboard" somewhere?

@DanielRuf
Copy link
Copy Markdown
Contributor Author

@DanielRuf the marked labels above + title sounds right to me. Are you saying there another "account dashboard" somewhere?

I did not change the "Account Dashboard" on the left but should also change this.

@VladimirZaets
Copy link
Copy Markdown
Contributor

Hi @DanielRuf, can you please also change "Account Dashboard" label. Thanks

@VladimirZaets
Copy link
Copy Markdown
Contributor

Hi @DanielRuf, I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for collaboration

@DanielRuf DanielRuf reopened this Jul 2, 2018
@DanielRuf
Copy link
Copy Markdown
Contributor Author

Please reopen and update if you wish to continue.

Done.

@VladimirZaets
Copy link
Copy Markdown
Contributor

Hi @DanielRuf , thanks for the update.

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @DanielRuf. Thank you for your contribution.
We will aim to release these changes as part of 2.2.6.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@DanielRuf DanielRuf deleted the fix/change-my-dashboard-to-my-account branch July 4, 2018 06:59
@DanielRuf
Copy link
Copy Markdown
Contributor Author

Backport failed on 2.1. Do we still need it for 2.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants