1334: CreateOrderBackendTest rework to support MSI 'Reorder' button new behaviour.#16006
Merged
magento-engcom-team merged 4 commits intomagento:2.3-developfrom Jun 18, 2018
nmalevanec:1334
Merged
1334: CreateOrderBackendTest rework to support MSI 'Reorder' button new behaviour.#16006magento-engcom-team merged 4 commits intomagento:2.3-developfrom nmalevanec:1334
magento-engcom-team merged 4 commits intomagento:2.3-developfrom
nmalevanec:1334
Conversation
Contributor
magento-engcom-team
pushed a commit
that referenced
this pull request
Jun 18, 2018
…der' button new behaviour. #16006
Contributor
|
Hi @nmalevanec. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add shipment step to CreateOrderBackendTest in order to support "Reorder" button new behaviour with enabled MSI magento/inventory#680
Standard magento behaviour - "Reorder" button hides immediately after place order, but with MSI "Reorder" button hides only after shipment created, as MSI introduces additional property for product as 'salable quantity'. And after order placement, 'salable quantity' decreasing, not quantity itself(more about reservation mechanism here). Quantity decreasing only after shipment creation. So, in order to pass CreateOrderBackendTest with MSI, additional step with shipment creation should be added into test before assertions.
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist
enterprise part: magento-engcom/magento2ee#161